Add aws card to missing aws docs #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre
approved these changes
Nov 8, 2024
| @@ -1,5 +1,7 @@ | |||
| = Using HTTPS | |||
There was a problem hiding this comment.
Is this file still in use? I couldn't find where it's linked on the left? Also, is it different than https://docs.killbill.io/latest/how-to-add-a-certificate-using-ACM ?
Maybe it's related to the clean-up work from Jim (#555)? Would be good to close the loop on that PR too.
There was a problem hiding this comment.
Maybe it's related to the clean-up work from Jim (#555)
Yes, it is possible, I'll double-check if this file is still in use.
| @@ -1,5 +1,7 @@ | |||
| = Using SES with AWS | |||
There was a problem hiding this comment.
Should we move all AWS related files under the userguide/aws directory?
There was a problem hiding this comment.
Yes, that makes sense. I will do this in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for https://github.com/killbill/technical-support/issues/173.