Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xray docs #539

Closed
wants to merge 4 commits into from
Closed

Update xray docs #539

wants to merge 4 commits into from

Conversation

vnandwana
Copy link
Contributor

Added steps to install xray daemon on standalone EC2.

@pierre pierre requested a review from reshmabidikar February 22, 2024 08:06
Copy link
Contributor

@reshmabidikar reshmabidikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some minor comments.


The features of the CloudFormation system include:

* Both Kill Bill and Kaui instances can be scaled up or down using AWS autoscaling groups
* Kill Bill and Kaui instance can be scaled up or down using AWS autoscaling groups
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rephrasing as

Suggested change
* Kill Bill and Kaui instance can be scaled up or down using AWS autoscaling groups
*The instance having Kill Bill/Kaui installed can be scaled up or down using AWS autoscaling groups

@@ -29,7 +29,7 @@ image::../assets/aws/cf_stack.png[align=center]

All resources for this system run within a single AWS *Virtual Private Cloud (VPC)*, providing a dedicated block of IP addresses which must be located in a single *region*. The cloud is partitioned into *availability zones*, which are accessed by *subnets*. The resources must be distributed over at least two availability zones.

Multiple instances of Kaui and the Kill Bill server are deployed in the VPC, each running on its own Ubuntu Linux server. AWS autoscaling is used to increase and decrease the number of instances for each package as needed.
A single instance of Kill Bill and Kaui servers is deployed in the VPC, running on an Ubuntu Linux server. AWS autoscaling is utilized to dynamically adjust the number of instances for each package based on demand, allowing for efficient scaling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rephrasing as

Suggested change
A single instance of Kill Bill and Kaui servers is deployed in the VPC, running on an Ubuntu Linux server. AWS autoscaling is utilized to dynamically adjust the number of instances for each package based on demand, allowing for efficient scaling.
A single instance having the Kill Bill/Kaui server is deployed in the VPC, running on an Ubuntu Linux server. AWS autoscaling is utilized to dynamically adjust the number of instances for each package based on demand, allowing for efficient scaling.

@vnandwana
Copy link
Contributor Author

@reshmabidikar I have rebased this branch to v3 but those changes are not reflected in this PR. I'm closing this PR and have opened a new one -- #540. Kindly take a look at it when you get a chance. Thank you.

@vnandwana vnandwana closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants