Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force PARENT edge coords in the JSON editor. #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skieffer
Copy link

@skieffer skieffer commented Nov 24, 2024

This ensures that Sprotty is able to draw the graph correctly, and is a part of the solution to eclipse/elk#901 .
It also resolves #8.

Note however that it won't do anything until elk-live is using a version of ELK that incorporates eclipse/elk#1071 .

It appears to be consistent with older/current versions of ELK, i.e. they appear to simply ignore the new property, and their behavior is unchanged.

This ensures that Sprotty is able to draw the graph correctly.
Conditional operator unnecessary
@skieffer
Copy link
Author

Question: Should it be made conditional on the selected ELK version?

I could move the added lines a bit lower, under here:

let selectedVersion = versionSelect.options[versionSelect.selectedIndex].value;

and make them kick in only if the numerical value of selectedVersion is large enough.

The reason for doing so would be to avoid passing earlier versions of ELK a property,
org.eclipse.elk.json.edgeCoords, that they don't know about.

But in testing, it seems to me that they don't care. All earlier versions seem to work just fine, even though I'm passing them an unknown property.

@soerendomroes
Copy link
Member

Question: Should it be made conditional on the selected ELK version?

I think this it is fine as it currently is. @Eddykasp do we have time for an ELK and elklive release this year?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly interpret edge coordinates
2 participants