Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker status display #122

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Tracker status display #122

merged 6 commits into from
Sep 8, 2023

Conversation

n1kPLV
Copy link
Contributor

@n1kPLV n1kPLV commented Sep 4, 2023

No description provided.

@n1kPLV n1kPLV marked this pull request as ready for review September 6, 2023 10:17
@n1kPLV n1kPLV force-pushed the tracker-components branch from d48a4f5 to 616a5fa Compare September 6, 2023 13:57
@n1kPLV
Copy link
Contributor Author

n1kPLV commented Sep 6, 2023

rebased onto current development

@n1kPLV n1kPLV requested a review from liamboddin September 6, 2023 15:21
@liamboddin
Copy link
Contributor

Looks fine to me. I just don't quite understand why whenever I hover with my mouse over one of the trackers in either the list of vehicles with their corresponding trackers or the tracker within a selected vehicle on the map, the name of the tracker is shown in some sort of hint

@n1kPLV
Copy link
Contributor Author

n1kPLV commented Sep 6, 2023

I just don't quite understand why whenever I hover with my mouse over one of the trackers in either the list of vehicles with their corresponding trackers or the tracker within a selected vehicle on the map, the name of the tracker is shown in some sort of hint

Longer tracker ids are truncated on smaller screens, so they won't overflow the available space. So to be able to still view the complete name, I added this tooltip-like thingy on hover.
I would have made it so that this only appears when the id is actually truncated, however from what I could find it is quite challenging to determine if some text is truncated by the browser.

@n1kPLV n1kPLV merged commit fc4dad3 into development Sep 8, 2023
2 checks passed
@JulianGrabitzky JulianGrabitzky deleted the tracker-components branch September 13, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants