-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-10214] Fix regression for immutable KIE container with auto scan #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmunozfe
added
backport-7.67.x
Generate backport PR for 7.67.x branch
backport-7.67.x-blue
Generate backport PR for 7.67.x-blue branch
labels
Dec 13, 2023
jenkins do fdb |
fjtirado
reviewed
Dec 15, 2023
...on/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java
Outdated
Show resolved
Hide resolved
fjtirado
approved these changes
Dec 15, 2023
…pring-boot-autoconfiguration/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
jenkins test this |
java.net.BindException: Address already in use /127.0.0.1:37006 Jenkins test this |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
jenkins do fdb |
Failed test in fdb is unrelated, BC; [org.kie.bc.DeploymentIT.org.kie.bc.DeploymentIT] |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
#3004) * [JBPM-10214] Fix regression for immutable KIE container with auto scan * Update kie-spring-boot/kie-spring-boot-autoconfiguration/kie-server-spring-boot-autoconfiguration/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> --------- Co-authored-by: gmunozfe <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
#3004) * [JBPM-10214] Fix regression for immutable KIE container with auto scan * Update kie-spring-boot/kie-spring-boot-autoconfiguration/kie-server-spring-boot-autoconfiguration/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> --------- Co-authored-by: gmunozfe <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
mareknovotny
pushed a commit
that referenced
this pull request
Jan 24, 2024
#3004) (#3012) * [JBPM-10214] Fix regression for immutable KIE container with auto scan * Update kie-spring-boot/kie-spring-boot-autoconfiguration/kie-server-spring-boot-autoconfiguration/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java --------- Co-authored-by: Gonzalo Muñoz <[email protected]> Co-authored-by: gmunozfe <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
mareknovotny
pushed a commit
that referenced
this pull request
Jan 24, 2024
#3004) (#3013) * [JBPM-10214] Fix regression for immutable KIE container with auto scan * Update kie-spring-boot/kie-spring-boot-autoconfiguration/kie-server-spring-boot-autoconfiguration/src/main/java/org/kie/server/springboot/autoconfiguration/KieServerAutoConfiguration.java --------- Co-authored-by: Gonzalo Muñoz <[email protected]> Co-authored-by: gmunozfe <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7.67.x
Generate backport PR for 7.67.x branch
backport-7.67.x-blue
Generate backport PR for 7.67.x-blue branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: JBPM-10214
explodedJarFolder
has a default value, i.e., it won't be null ever. As we want to keep the previous behavior, the best way IMHO without adding more configuration is to try the exploded option first and, if not present, try to autoscan the fat-jar.How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.