Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(studies): SKFP-767 filter without footer #3835

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

AltefrohneGaelle
Copy link
Collaborator

@AltefrohneGaelle AltefrohneGaelle commented Nov 1, 2023

#[FEATURE] Remove apply and clear button in filters

Description

SKFP-767

Acceptance Criterias

Remove buttons in the facets to(CLEAR, Apply). As soon as there is a value that is selected, it will automatically be added to the query builder.

Validation

  • Code Approved
  • Test Coverage
  • QA Done
  • Design/UI Approved from design

Screenshot

Before

Capture d’écran, le 2023-11-01 à 08 48 31

After

Capture d’écran, le 2023-11-01 à 08 47 02

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for portal-pre-prod-kidsfirstdrc ready!

Name Link
🔨 Latest commit c4f7ced
🔍 Latest deploy log https://app.netlify.com/sites/portal-pre-prod-kidsfirstdrc/deploys/6542495c596f4a000852e116
😎 Deploy Preview https://deploy-preview-3835--portal-pre-prod-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for portal-qa-next-kidsfirstdrc ready!

Name Link
🔨 Latest commit c4f7ced
🔍 Latest deploy log https://app.netlify.com/sites/portal-qa-next-kidsfirstdrc/deploys/6542495cc942b100083ec81a
😎 Deploy Preview https://deploy-preview-3835--portal-qa-next-kidsfirstdrc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 1, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from c4f7ced

@AltefrohneGaelle AltefrohneGaelle merged commit bb8b6c5 into 2.0 Nov 1, 2023
7 checks passed
@AltefrohneGaelle AltefrohneGaelle deleted the feat/SKFP-767-studies-remove-apply-clear branch November 1, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants