fix(variant): SKFP-804 fix protein coding display #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for portal-qa-next-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for portal-pre-prod-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from 2f9b8e1 |
ethienneroy
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] Variant entity, fix protein coding value display
Description
SKFP-804
If the value is 0 it's the real value, we want to display it. If the value is not defined we received null/undefined.
Validation
Screenshot
Before
spliceAi value 0
gnomad pli value 0
We don't have an example for gnomad loeuf with 0 value.
After