Skip to content

Commit

Permalink
Fixed #457 - Inconsistent documentation of minimum required Maven ver…
Browse files Browse the repository at this point in the history
…sion

- 3.8.1 as been agreed upon to be the minimum for now
- gh-pages need to refreshed from adoc
- added link to contribution guide as well
- updated release notes
  • Loading branch information
JOpsDev authored and khmarbaise committed Apr 13, 2024
1 parent 2a189b6 commit 470bbb0
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Of course there is a lot of convenience integrated into it to make integration t
The requirements to write integration tests with the integration testing framework are the following:

* JDK8+
* Apache Maven 3.8.4 or above.
* Apache Maven 3.8.1 or above.

## The Maven Configuration

Expand Down Expand Up @@ -322,6 +322,11 @@ Code coverage via:
```bash
mvn clean verify org.jacoco:jacoco-maven-plugin:report
```

# Contributing

If you want to contribute, there is a [contribution guide](CONTRIBUTING.md) for you.


[food]: https://en.wikipedia.org/wiki/Eating_your_own_dog_food
[jdkbuilds]: https://github.com/khmarbaise/maven-it-extension/actions?query=workflow%3AJDKBuilds
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
:issue-458: https://github.com/khmarbaise/maven-it-extension/issues/458[Fixed #458]
:issue-463: https://github.com/khmarbaise/maven-it-extension/issues/463[Fixed #463]
:issue-464: https://github.com/khmarbaise/maven-it-extension/issues/464[Fixed #464]
:issue-457: https://github.com/khmarbaise/maven-it-extension/issues/457[Fixed #457]
:pr-462: https://github.com/khmarbaise/maven-it-extension/pull/262[Pull request #462]

:release_0_14_0: https://github.com/khmarbaise/maven-it-extension/milestone/14

Expand All @@ -50,9 +52,10 @@
** Removed `@MavenDebug` (related to {issue-379})
** Removed `MavenVersion.UNKNOWN` (related to {issue-421})

*Reporter of this release*
*Contributors of this release*

* {issue-???} - ?
* https://github.com/JOpsDev[Tobias Frech] with {pr-462}
** Inconsistent documentation of minimum required Maven version

*Dependency Upgrades*

Expand All @@ -74,6 +77,7 @@

* {issue-444} - Upgrade central link
* {issue-449} - Runtime requirement in docs is wrongly Maven 3.1.0
* {issue-457} - Inconsistent documentation of minimum required Maven version


The full release notes can be found here {release_0_14_0}[Release 0.14.0].
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ of this extension.
The requirements are:

* JDK8+
* Apache Maven 3.6.3 or above.
* Apache Maven 3.8.1 or above.

The first step is to add the appropriate dependencies to your project. They are usually with `test` scope,
cause you only need them during the integration tests.
Expand Down
2 changes: 2 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@
<automatic-module-name>com.soebes.itf.extension</automatic-module-name>
<maven-plugin-plugin.version>3.10.2</maven-plugin-plugin.version>
<maven-resolver.version>1.9.18</maven-resolver.version>
<!-- The minimum maven version we expect to build with. -->
<minimum.maven.version>3.8.1</minimum.maven.version>
</properties>

<dependencyManagement>
Expand Down

0 comments on commit 470bbb0

Please sign in to comment.