Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #42 added social media panel #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Priyanka7011
Copy link

@Priyanka7011 Priyanka7011 commented Mar 13, 2021

Related Issuse #42

  • Info about Issue or bug

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

added social media icons

Checklist:

  • [x ] My code follows the style guidelines of this project.

[x ] I have performed a self-review of my own code.

  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [x ] My changes generate no new warnings.

Screenshots

Screenshot_62

Original Updated
original screenshot updated screenshot

@CodesbyUnnati
Copy link
Collaborator

Related Issuse #42

  • Info about Issue or bug

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

added social media icons

Checklist:

  • [x ] My code follows the style guidelines of this project.

[x ] I have performed a self-review of my own code.

  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [x ] My changes generate no new warnings.

Screenshots

Screenshot_62

Original Updated
original screenshot updated screenshot

image
Don't commit the changed password, let it be blank and the icons of the social media are not clickable. Pl change that.

@Priyanka7011
Copy link
Author

Okay I will do that
Thank You

@Priyanka7011
Copy link
Author

I've made the changes. Please review it

@CodesbyUnnati
Copy link
Collaborator

image
The icons are not clickable to me. If it is working for you then Pl upload a picture of it.

@Priyanka7011
Copy link
Author

Priyanka7011 commented Mar 23, 2021

WhatsApp Image 2021-03-23 at 4 01 06 PM
@CodesbyUnnati yes ma'am icons are clickable.
Actually I have not attached any link to the icons that's why they are not redirecting to new page.
Screenshot_70
Here in class SocialMedia instead of href="#" if you will put your social media link then it will redirect to your social media account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants