Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dark Mode #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Dark Mode #149

wants to merge 2 commits into from

Conversation

rupal121
Copy link

@rupal121 rupal121 commented Apr 7, 2021

Related Issuse

Added Dark mode with a smooth transition.

Closes: Issue #139

Describe the changes you've made

Added dark mode to the home page using html, css and js.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots

ORIGINAL:
2021-04-07 (5)
UPDATED:
2021-04-07
2021-04-07 (3)
2021-04-07 (4)

rupal121 added 2 commits April 7, 2021 15:36
added toggle button for dark mode
Added CSS for dark mode
@rupal121
Copy link
Author

rupal121 commented Apr 9, 2021

Please review @khannakshat7 @CodesbyUnnati Issue #139

@khannakshat7
Copy link
Owner

@rupal121 You have not implemented the dark mode correctly as when u switch to dark mode the whole website should be in dark mode but in ur case when I refresh the page it is restored back to light mode.
Means it only changes to dark mode when switch is on and when I refresh the page it is back to light theme.
So pl. try to resolve this issue

@rupal121
Copy link
Author

Okay

@arpit456jain
Copy link
Contributor

@rupal121 are you working on this issue or I can try it.

@rupal121
Copy link
Author

@arpit456jain I am working on it.

@arpit456jain
Copy link
Contributor

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants