Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi there! #27

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Hi there! #27

wants to merge 9 commits into from

Conversation

benwainwright
Copy link

@benwainwright benwainwright commented Jul 1, 2021

Really nice plugin! I thought I'd spend a bit of time implementing one of the features on your wishlist, because with a bit of work I can really see myself using this plugin in my workflow. I'd love to see this merged, so let me know if you'd like me to change anything

Changes in this PR

  • Added TypeScript compile to the prepare hook (webpack doesn't do type checking, so there were lots of type errors)
  • Fixed all the type errors
  • Formatted the code with prettier
  • Add sign in the gutter at the start of a test when it passes or fails
  • Parse the actual assertion failure location out of the error message and use that to place your diagnostic
  • Add some status bar messages so the user knows what is going on

@benwainwright benwainwright reopened this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant