use CastToObjectVectorProcessor for cast to string (apache#17148)

kfaraz · Sep 24, 2024 · 0ec7eb3 · 0ec7eb3
1 parent 83299e9
commit 0ec7eb3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 55 deletions.
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/CastToStringVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/CastToStringVectorProcessor.java
diff --git a/processing/src/main/java/org/apache/druid/math/expr/vector/CastToTypeVectorProcessor.java b/processing/src/main/java/org/apache/druid/math/expr/vector/CastToTypeVectorProcessor.java
@@ -42,9 +42,6 @@ public static <T> ExprVectorProcessor<T> cast(
       caster = castInput;
     } else {
       switch (castToType.getType()) {
-        case STRING:
-          caster = new CastToStringVectorProcessor(castInput, maxVectorSize);
-          break;
         case LONG:
           caster = new CastToLongVectorProcessor(castInput);
           break;

diff --git a/processing/src/test/java/org/apache/druid/math/expr/VectorExprSanityTest.java b/processing/src/test/java/org/apache/druid/math/expr/VectorExprSanityTest.java
@@ -271,6 +271,16 @@ public void testArrayFns()
     testExpression("array(s1, l2)", types);
   }
 
+  @Test
+  public void testCastArraysRoundTrip()
+  {
+    testExpression("cast(cast(s1, 'ARRAY<STRING>'), 'STRING')", types);
+    testExpression("cast(cast(d1, 'ARRAY<DOUBLE>'), 'DOUBLE')", types);
+    testExpression("cast(cast(d1, 'ARRAY<STRING>'), 'DOUBLE')", types);
+    testExpression("cast(cast(l1, 'ARRAY<LONG>'), 'LONG')", types);
+    testExpression("cast(cast(l1, 'ARRAY<STRING>'), 'LONG')", types);
+  }
+
   @Test
   public void testJsonFns()
   {