PR: demo with change order sign and Unit-Test #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Approach to execution transaction
…ssion Over Target Safe
…uard in Sepolia, with new approach of ExecutionOnBehalf for Demo
…half-method ADD: first draft new approach execution On Behalf, aligned with Safe Approach to execution transaction
…ehalf with different order in the signatures
…half-method FIX: adjust for Run Unit-Test in Fork-Polygon
jozer-rami
changed the title
jozer-rami
reviewed
Mar 25, 2024
.env.example
Outdated
| ### Keyper Contracts deployed | ||
| # # Kovan deployed versions |
script/SkipExecutionOnBehalf.s.sol
Outdated
Comment on lines
15
to
25
| // testCannot_ExecTransactionOnBehalf_Wrapper_ExecTransactionOnBehalf_ChildSquad_over_RootSafe_With_SAFE(); // ✅ | ||
| // testCannot_ExecTransactionOnBehalf_Wrapper_ExecTransactionOnBehalf_ChildSquad_over_RootSafe_With_EOA(); // ??? | ||
| // testCan_ExecTransactionOnBehalf_ROOT_SAFE_as_SAFE_is_TARGETS_ROOT_SameTree(); // ✅ | ||
| // testCan_ExecTransactionOnBehalf_as_EOA_is_NOT_ROLE_with_RIGHTS_SIGNATURES(); // ✅ | ||
| // testCan_ExecTransactionOnBehalf_SUPER_SAFE_as_SAFE_is_TARGETS_LEAD_SameTree(); // ✅ | ||
| // testRevert_ExecTransactionOnBehalf_as_EOA_is_NOT_ROLE_with_WRONG_SIGNATURES(); // ✅ | ||
| // testRevert_ExecTransactionOnBehalf_as_EOA_is_NOT_ROLE_with_INVALID_SIGNATURES(); // ✅ | ||
| // testRevertInvalidSignatureExecOnBehalf(); // ✅ | ||
| // testRevertInvalidAddressProvidedExecTransactionOnBehalfScenarioOne(); // ✅ | ||
| // testRevertZeroAddressProvidedExecTransactionOnBehalfScenarioTwo(); // ✅ | ||
| // testRevertSuperSafeExecOnBehalf(); // ✅ |
There was a problem hiding this comment.
We need to add a comment why we're disabling this tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.