-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(developer): Support v2.0 projects in TIKE 🦕 #9949
Conversation
Relates to #9948. Starts basic support for v2.0 projects. For all operating modes: - Remove blank projects / untitled projects mode - Add Open Project Folder buttons and links - Remove Project Save As - Render uses in-memory XML - Upgrade to v2.0 project file (along with checks) For v2.0 projects: - Remove 'Add File to Project' - Populate Files to list all files in folder (note: consider efficiency here as currently files are parsed for subfile data) - Version 2.0 project options and defaults
User Test ResultsTest specification and instructions
Test Artifacts |
Yes, that is an expected message, looks good thank you. (A future PR will also make those messages clearer) |
if DirectoryExists(FFileName) then | ||
begin | ||
// This is an attempt to open a project folder? | ||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this get a warning message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's a TODO to finish the functionality; captured in #9948.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes in this pull request will be available for download in Keyman version 17.0.211-alpha |
Relates to #9948. See that issue for remaining work items.
This PR starts basic support for v2.0 projects.
For all operating modes:
For v2.0 projects:
here as currently files are parsed for subfile data)
User Testing
TEST_OPEN_PROJECT: Verify that opening an existing project continues to function correctly. Try basic project functions, such as opening files in the project, building keyboards (from the buttons in the Project view), adding files.
TEST_NEW_PROJECT: Verify that creating a new basic keyboard project continues to function correctly.
TEST_UPGRADE_PROJECT: When opening an existing project, an Upgrade banner should appear. Click the button to upgrade the project, and follow the prompts. Load the result .kpj file in a text editor and verify (a) that the
<Version>
field now reads '2.0', and (b) that there are no<File>
entries in the .kpj file.