chore(linux): Refactor deb-packaging.sh script 🎬 #9866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make use of builder_run_action.
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
changed the title
mcdurdin
reviewed
Oct 27, 2023
Comment on lines
+68
to
+70
| builder_run_action dependencies dependencies_action | ||
| builder_run_action source source_action | ||
| builder_run_action verify verify_action |
There was a problem hiding this comment.
I notice you are no longer doing exit 0 after each action. Is this change in behaviour intentional?
There was a problem hiding this comment.
Yes, this brings it more in line with how the other build.sh scripts work. I can't see a reason why you shouldn't be able to run multiple actions.
There was a problem hiding this comment.
Sounds sensible to me. Just wasn't sure if there was a particular reason it was doing that before 😁
ermshiperete
force-pushed
the
chore/linux/9548_manualTrigger
branch
5 times, most recently
from
898e8e7 to
517c300
Compare
|
Changes in this pull request will be available for download in Keyman version 17.0.205-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of builder_run_action.
@keymanapp-test-bot skip