fix(developer): handle displayMap correctly with 'fill from layout' #9861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9851. Two fixes: * errors from loading the displayMap from disk should be handled before passing result to next function * temp compile of the .kmn for the 'fill from layout' function should be in the same path as the original .kmn, so that referenced files can be located
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
deleted the
fix/developer/9851-fill-from-layout-displaymap-path
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.201-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9851.
Two fixes:
@keymanapp-test-bot skip
(User test involves setting up a
&displayMapwhich is a bit too involved to be feasible right now... I have tested locally.)