fix(web): proper disabling of prediction timeout for prediction unit tests #9835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'd previously added a "test mode" flag for use in prediction-oriented unit tests... it appears I somehow completely forgot to actually use it in the unit test specs. This remedies that little issue.
From the
ModelCompositor
definition inlm-worker
:keyman/common/web/lm-worker/src/main/model-compositor.ts
Lines 32 to 41 in 8a483fc
keyman/common/web/lm-worker/src/main/model-compositor.ts
Lines 243 to 244 in 8a483fc
But... so many unit tests forgot to actually specify the parameter. 😦
@keymanapp-test-bot skip