Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): server download Keyman link #9822

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Oct 22, 2023

Fixes #9702.

User Testing

Setup: you will need to have Keyman Developer Server running on your Windows computer for all these tests, in the same way as described in #9702. Then, you will need to locate the appropriate IP address on your local network for your computer, and ensure that the test devices are on the same local network. For example, on my machine, the address I use is http://192.168.129.109:8008:

image

Then, open that page on the target device and test the Download Keyman link there.

GROUP_WINDOWS: Test on Windows
GROUP_MAC: Test on MacOS
GROUP_ANDROID: Test on MacOS
GROUP_IOS: Test on iOS
GROUP_LINUX: Test on Linux

TEST_LINK: Test ths the Download Keyman link starts a download for Keyman or loads a page appropriate for the device

@mcdurdin mcdurdin requested a review from darcywong00 as a code owner October 22, 2023 22:27
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 22, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 22, 2023

User Test Results

Test specification and instructions

  • ✅ GROUP_WINDOWS: Test on Windows

    1 tests PASSED
    • TEST_LINK (PASSED): Tested with the attached PR build (Keyman Developer 17.0.196-alpha-test-9822) on Windows 11 OS (VM) and here is my observation: 1. Able to see the Keyman Server is running in the background. (the icon is displayed in the taskbar). 2. Opened the test page in the local browser on the target device (Windows) then clicked the Download Keyman link there. 3. Verified that clicking the Download link button would initiate the download of the Keyman stable build. (notes)
  • ✅ GROUP_MAC: Test on MacOS

    1 tests PASSED
    • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (macOS) and then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build. (notes)
  • ✅ GROUP_ANDROID: Test on MacOS

    1 tests PASSED
    • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (Nexus 9) then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build. (notes)
  • ✅ GROUP_IOS: Test on iOS

    1 tests PASSED
    • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (iPhone 5S) then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build. (notes)
  • ✅ GROUP_LINUX: Test on Linux

    1 tests PASSED
    • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (Linux) then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build. (notes)

Test Artifacts

Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bharanidharanj
Copy link

Test Results

GROUP_WINDOWS: Test on Windows

  • TEST_LINK (FAILED): Tested with Keyman Developer 17.0.196-alpha-test-9822 (downloaded it from TeamCity) in both Windows 10 (Native) OS and here is my observation: 1. In Windows 10 OS, I got a warning message 'Keyman Developer Server has not yet started successfully. Keep waiting?". Clicking the OK button repeats this message on the screen.

@mcdurdin
Copy link
Member Author

  • Tested with Keyman Developer 17.0.196-alpha-test-9822 (downloaded it from TeamCity) in both Windows 10 (Native) OS and here is my observation: 1. In Windows 10 OS, I got a warning message 'Keyman Developer Server has not yet started successfully. Keep waiting?". Clicking the OK button repeats this message on the screen.

@bharanidharanj I tried but was unable to reproduce this problem. Can you re-test this, and look to see if the Keyman Developer Server has started down in the system notification area?

@mcdurdin
Copy link
Member Author

@keymanapp-test-bot retest

@bharanidharanj
Copy link

  • Tested with Keyman Developer 17.0.196-alpha-test-9822 (downloaded it from TeamCity) in both Windows 10 (Native) OS and here is my observation: 1. In Windows 10 OS, I got a warning message 'Keyman Developer Server has not yet started successfully. Keep waiting?". Clicking the OK button repeats this message on the screen.

@bharanidharanj I tried but was unable to reproduce this problem. Can you re-test this, and look to see if the Keyman Developer Server has started down in the system notification area?

Sure @mcdurdin . I will re-test it and will post my result.

@bharanidharanj
Copy link

Test Results

GROUP_WINDOWS: Test on Windows

  • TEST_LINK (PASSED): Tested with the attached PR build (Keyman Developer 17.0.196-alpha-test-9822) on Windows 11 OS (VM) and here is my observation: 1. Able to see the Keyman Server is running in the background. (the icon is displayed in the taskbar). 2. Opened the test page in the local browser on the target device (Windows) then clicked the Download Keyman link there. 3. Verified that clicking the Download link button would initiate the download of the Keyman stable build.

..Opened the web page in the given web address link

..Download link working in Windows target device

GROUP_MAC: Test on MacOS

  • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (macOS) and then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build.

GROUP_ANDROID: Test on Android

  • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (Nexus 9) then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build.

GROUP_IOS: Test on iOS

  • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (iPhone 5S) then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build.

GROUP_LINUX: Test on Linux

  • TEST_LINK (PASSED): 1. Opened the test page in the local browser on the target device (Linux) then clicked the Download Keyman link there. 2. Verified that clicking the Download link button would initiate the download of the Keyman stable build.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 25, 2023
@mcdurdin mcdurdin merged commit 72f7a6e into master Oct 26, 2023
2 checks passed
@mcdurdin mcdurdin deleted the fix/developer/9702-server-download-keyman-link branch October 26, 2023 02:46
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.199-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants