feat(linux): Allow loading of keyboards with arbitrary language 🏘️ #9735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
force-pushed
the
feat/linux/8598_arbitrary-lang
branch
from
c4f241e to
2ae4953
Compare
ermshiperete
force-pushed
the
feat/linux/8598_arbitrary-lang
branch
from
2ae4953 to
3ec376f
Compare
ermshiperete
force-pushed
the
feat/linux/8598_arbitrary-lang
branch
from
2d3ca9d to
b0dd74c
Compare
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
approved these changes
Oct 16, 2023
| cust_kbd *kbd_data = (cust_kbd *)data; | ||
|
|
||
| g_free(kbd_data->kb_id_with_lang); | ||
| g_free(kbd_data->lang->id); |
There was a problem hiding this comment.
should we null check kbd_data->lang as well for safety?
There was a problem hiding this comment.
We always allocate kbd_data->lang immediately after allocating kbd_data, so I don't think there's a need for that. In fact, checking for kbd_data->lang->name is unnecessary as well since g_free will return if the parameter is NULL.
`g_free` will return if the parameter is NULL, so we don't have to check for that. See glib [documentation](https://docs.gtk.org/glib/func.free.html).
|
Changes in this pull request will be available for download in Keyman version 17.0.192-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8598.
User tests will be part of the next PR that implements the necessary changes in keyman-config.
@keymanapp-test-bot skip