chore(linux): Improve Sentry reports #9725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hash` method that we previously used calculates the hash based on the memory location, i.e. with each program run we get a different value for the same user. This change now uses the md5 algorithm so that the same user always produces the same hash.
This change adds additional details to Sentry events so that the "All Events" tab on keyman.sentry.io will show helpful values in the "device" and "os" columns instead of emptry strings.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
reviewed
Oct 9, 2023
Comment on lines
+128
to
+130
| hash = hashlib.md5() | ||
| hash.update(getpass.getuser().encode()) | ||
| set_user({'id': hash.hexdigest()}) |
There was a problem hiding this comment.
I'm not sure about this -- md5 hashes of short strings are pretty easy to reverse with rainbow tables. It's low risk but it is a bit of an overshare.
There was a problem hiding this comment.
So better use sha256?
mcdurdin
approved these changes
Oct 10, 2023
|
Changes in this pull request will be available for download in Keyman version 17.0.187-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashfunction calculates the hash based on the memory location.@keymanapp-test-bot skip