-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): rename keyboardprocessor.h to keyman_core_api.h #9723
chore(core): rename keyboardprocessor.h to keyman_core_api.h #9723
Conversation
Fixes #9721. Also tweaks some documentation references to keyboardprocessor, but does not touch those relating to debian/control.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Looks fine. I don't quite understand what is required but do we do need to make changes to the api_version.in or the name of the built library to match this comment fcitx/fcitx5-keyman#3 (comment). |
@ermshiperete thoughts? |
The names in We should rename the library to |
oops okay! Do you want to revert that specific change and put in place what should be done instead? Also, |
Ok, I'll take care of the .symbols file when I do #9733. |
Changes in this pull request will be available for download in Keyman version 17.0.187-alpha |
Fixes #9721.
Also tweaks some documentation references to keyboardprocessor, but does not touch those relating to debian/control.
@keymanapp-test-bot skip