Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): stop using xml2js.processors.firstCharLowerCase 🎺 #9714

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Oct 8, 2023

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 8, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Android
    • Keyman for Android apk - build pending
    • FirstVoices for Android 16.0 apk - build pending
    • FirstVoices Keyboards for Android apk - build pending
    • Keyman for Android 16.0 apk - build pending
  • iOS
    • Keyman for iOS (simulator image) - build pending
    • FirstVoices Keyboards for iOS (simulator image) - build pending
  • Web
    • KeymanWeb Test Home - build pending

@keymanapp-test-bot keymanapp-test-bot bot changed the title chore(common): stop using xml2js.processors.firstCharLowerCase chore(common): stop using xml2js.processors.firstCharLowerCase 🎺 Oct 8, 2023
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S23 milestone Oct 8, 2023
name: string; /// the descriptive name of the keyboard
iD: string; /// the keyboard identifier, equal to the basename of the keyboard file sans extension
version: string;
oSKFont?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahorton this should make you happy 😉

Base automatically changed from fix/developer/9266-non-minimal-tags-as-hint to epic/package-metadata October 11, 2023 00:19
@mcdurdin mcdurdin merged commit 98af605 into epic/package-metadata Oct 11, 2023
2 checks passed
@mcdurdin mcdurdin deleted the chore/common/9713-avoid-xml2js-firstCharLowerCase branch October 11, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: stop using xml2js.processors.firstCharLowerCase conversion of element and attribute names in kps reader
2 participants