-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linux): Explicitly initialize GTK #9706
Conversation
Usually this is done automatically. However, if e.g. no `DISPLAY` variable is set it'll fail. When we explicitly initialize GTK it still fails, but shows a more helpful warning instead of throwing a runtime error. Fixes #9705.
User Test ResultsTest specification and instructions
Test Artifacts
|
@bharanidharanj I tried and it works for me on Lunar. Can you please try again? And if it fails again run @keymanapp-test-bot retest |
ok, so the problem is that @keymanapp-test-bot retest |
Test failed because of incomplete test instructions. It can't be tested with Wayland but has to be tested with X11. |
Changes in this pull request will be available for download in Keyman version 17.0.187-alpha |
Usually this is done automatically. However, if e.g. no
DISPLAY
variable is set it'll fail. When we explicitly initialize GTK it still fails, but shows a more helpful warning instead of throwing a runtime error.Fixes #9705.
User Testing
Preparations
The test should be run on any Linux platform with X11:
Install build artifacts of this PR
Reboot
Tests
TEST_WARNING: if
DISPLAY
is not set we should get a warning instead of a runtime errorunset DISPLAY
km-config
Gtk-WARNING **: 16:51:19.867: cannot open display:
. There should be no lines containing the textRuntimeError
.