fix(windows): re-enable signature check 🔥 #9695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9692. Signature checking was skipped because we missed a ".virtual" to force nmake to build the test and test_i3633 targets. This opened up a small cascade of related formatting issues on Makefiles, and the fact that the test_i3633 (has there ever been a more poorly named project?) Makefile did not even work. Refactored significantly, added same tests to Developer Makefile, and also now verifying the .msi and installer executable. We can improve this further but I'd like to get this in to avoid further critical issues with code signing given the current broken signing configuration.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
8 tasks
mcdurdin
requested review from
rc-swag,
ermshiperete and
darcywong00
as code owners
rc-swag
reviewed
Oct 9, 2023
| $(SIGCHECK) $(ROOT)\bin\inst\* >> sig1 | ||
| $(VERIFY_SIGNATURES) < sig1 | ||
|
|
||
| # prereq may not be needed? |
There was a problem hiding this comment.
Why this comment? I think the prereq is needed to build the verify_signatures binary
There was a problem hiding this comment.
The prereq may already have been built, but it's not a big deal because it builds quickly anyway.
rc-swag
approved these changes
Oct 9, 2023
|
Changes in this pull request will be available for download in Keyman version 17.0.187-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9692.
Signature checking was skipped because we missed a ".virtual" to force nmake to build the test and test_i3633 targets. This opened up a small cascade of related formatting issues on Makefiles, and the fact that the test_i3633 (has there ever been a more poorly named project?) Makefile did not even work.
Refactored significantly, added same tests to Developer Makefile, and also now verifying the .msi and installer executable.
We can improve this further but I'd like to get this in to avoid further critical issues with code signing given the current broken signing configuration.
@keymanapp-test-bot skip