chore(linux): Fix bug with incomplete parameter in run-tests.sh, add dependency and update documentation #9602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
force-pushed
the
chore/linux/fixbug
branch
from
c5e9436 to
704ba55
Compare
Could you come up with a more descriptive title please? 😁 |
When running the integration tests, we provide a test service that replaces `keyman-system-service`. DBus needs the updated `.service` files in the `services` directory so that it will use the test service. This change outputs an error and returns an non-zero exit code if it can't find the `services` directory, which usually means that `keyman-system-service` didn't get build.
ermshiperete
force-pushed
the
chore/linux/fixbug
branch
from
ad01caf to
5d074b0
Compare
ermshiperete
changed the title
For integration tests ibus-keyman requires keyman-system-service to be built, so we add this as a dependency.
ermshiperete
force-pushed
the
chore/linux/fixbug
branch
from
5d074b0 to
3d8cf18
Compare
This change updates gha-ubuntu-packaging to a version that creates a non-empty changelog entry. This prevents a warning during package build.
This no longer suppresses the output of cleanup.
|
Changes in this pull request will be available for download in Keyman version 17.0.178-alpha |
|
Hmm, 'fix bugs' is still not clear! Would be better to state which bugs this PR is fixing |
ermshiperete
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servicesdirectory@keymanapp-test-bot skip