refactor(linux): Add more tests for keymanutil.c 🏘️
#9595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermshiperete
changed the title
keymanutil.ckeymanutil.c 🏘️
User Test ResultsTest specification and instructions User tests are not required |
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
force-pushed
the
refactor/linux/keymanutil-tests
branch
from
c9cac51 to
f1bd6b8
Compare
ermshiperete
force-pushed
the
chore/linux/fixbug
branch
from
ad01caf to
5d074b0
Compare
ermshiperete
force-pushed
the
refactor/linux/keymanutil-tests
branch
from
f1bd6b8 to
9aab576
Compare
ermshiperete
force-pushed
the
chore/linux/fixbug
branch
from
5d074b0 to
3d8cf18
Compare
ermshiperete
force-pushed
the
refactor/linux/keymanutil-tests
branch
from
9aab576 to
35e0523
Compare
ermshiperete
force-pushed
the
refactor/linux/keymanutil-tests
branch
3 times, most recently
from
9715d5b to
f51b8b7
Compare
ermshiperete
force-pushed
the
refactor/linux/keymanutil-tests
branch
from
f51b8b7 to
ceb937f
Compare
Also add guard to kmpdetails.h.
ermshiperete
force-pushed
the
refactor/linux/keymanutil-tests
branch
2 times, most recently
from
3d0f07b to
20d2ed5
Compare
ermshiperete
force-pushed
the
refactor/linux/keymanutil-tests
branch
from
20d2ed5 to
3812a1d
Compare
darcywong00
reviewed
Sep 28, 2023
linux/ibus-keyman/src/keymanutil.c
Outdated
| @@ -416,47 +445,37 @@ keyman_put_options_todconf(gchar *package_id, | |||
|
|
|||
| // Obtain keyboard options from DConf | |||
| gchar **options = keyman_get_options_fromdconf(package_id, keyboard_id); | |||
There was a problem hiding this comment.
Do you want to match l. 397?
Suggested change
| gchar **options = keyman_get_options_fromdconf(package_id, keyboard_id); | |
| g_auto(GStrv) options = keyman_get_options_fromdconf(package_id, keyboard_id); |
darcywong00
reviewed
Sep 28, 2023
| } | ||
|
|
||
| add_keyboard_data* | ||
| _get_keyboard_data() { |
There was a problem hiding this comment.
Ah, initially I wondered why _get_kmp_foo() and _get_keyboard_foo() weren't in kmpdetails.c, but I see these generate test stubs. Since the keyboard ID is tst, I suggest _get_tst_ prefixes.
To me, that would make it a little clearer some of the info isn't coming from kmp.json. (ll 36-39)
There was a problem hiding this comment.
I couldn't think of a name that would make it clearer, but using tst is a good suggestion.
ermshiperete
commented
Sep 29, 2023
|
Changes in this pull request will be available for download in Keyman version 17.0.183-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip