Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fix handling of fonts with single quotes in filename 🍒 🏠 #13041

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

jahorton
Copy link
Contributor

Cherry-pick-of: #13032, but without the data URL components, as that tidbit was added during 18.0-alpha.

User Testing

This is how the default layer of the keyboard looks in desktop-mode Keyman Engine for Web:

Screenshot 2025-01-24 at 12 56 44 PM
  • TEST_ANDROID: Using the Android test build from this PR and the soninke_n_ti.kmp package from https://jahorton.github.io/soninke_n_ti.kmp, verify that the keyboard loads properly and has proper characters for its font.

  • TEST_IOS: Using the Android test build from this PR and the soninke_n_ti.kmp package from https://jahorton.github.io/soninke_n_ti.kmp, verify that the keyboard loads properly and has proper characters for its font.

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 24, 2025
@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(web): fix handling of fonts with single quotes in filename 🍒 fix(web): fix handling of fonts with single quotes in filename 🍒 🏠 Jan 24, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S20 milestone Jan 24, 2025
@github-actions github-actions bot added web/ cherry-pick Change already merged into another (stable) branch fix labels Jan 24, 2025
@dinakaranr
Copy link

Test Results

I tested this issue with the attached "17.0.334-test-13041" build(24/01/2025) on Android 14 and iPhone 13(iOS 17.4). Here is my observation.

  • TEST_ANDROID (Passed):
  1. Installed the "Keyman-17.0.334.apk" file from this PR build.
  2. Open the Keyman app.
  3. Checked the "Enable Keyman as system-wide keyboard". Set the keyboard as the default keyboard box on the settings page.
  4. Installed the "soninke_n_ti.kmp" which is attached to this PR.
  5. Verified that the keyboard loads properly
  6. Verified that the characters appear correctly when typing on it.
    It works well.
  • TEST_IOS (Passed):
  1. Installed the "Keyman-17.0.334.dmg" file from this PR build.
  2. Open the Keyman app.
  3. Checked the "Enable Keyman as system-wide keyboard". Set the keyboard as the default keyboard box on the settings page.
  4. Installed the "soninke_n_ti.kmp" which is attached to this PR.
  5. Verified that the keyboard loads properly
  6. Verified that the characters appear correctly when typing on it.
    It works well. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 24, 2025
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jahorton jahorton merged commit 0bddb6f into stable-17.0 Jan 27, 2025
16 checks passed
@jahorton jahorton deleted the fix/web/cherrypick-font-link-robustness branch January 27, 2025 01:10
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick Change already merged into another (stable) branch fix has-user-test stable web/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants