-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): fix handling of fonts with single quotes in filename 🍒 🏠 #13041
Merged
jahorton
merged 4 commits into
stable-17.0
from
fix/web/cherrypick-font-link-robustness
Jan 27, 2025
Merged
fix(web): fix handling of fonts with single quotes in filename 🍒 🏠 #13041
jahorton
merged 4 commits into
stable-17.0
from
fix/web/cherrypick-font-link-robustness
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
labels
Jan 24, 2025
User Test ResultsTest specification and instructions Test Artifacts
|
keymanapp-test-bot
bot
changed the title
fix(web): fix handling of fonts with single quotes in filename 🍒
fix(web): fix handling of fonts with single quotes in filename 🍒 🏠
Jan 24, 2025
github-actions
bot
added
web/
cherry-pick
Change already merged into another (stable) branch
fix
labels
Jan 24, 2025
Test ResultsI tested this issue with the attached "17.0.334-test-13041" build(24/01/2025) on Android 14 and iPhone 13(iOS 17.4). Here is my observation.
|
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
Jan 24, 2025
darcywong00
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes in this pull request will be available for download in Keyman version 17.0.334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick-of: #13032, but without the data URL components, as that tidbit was added during 18.0-alpha.
User Testing
This is how the default layer of the keyboard looks in desktop-mode Keyman Engine for Web:
TEST_ANDROID: Using the Android test build from this PR and the
soninke_n_ti.kmp
package from https://jahorton.github.io/soninke_n_ti.kmp, verify that the keyboard loads properly and has proper characters for its font.TEST_IOS: Using the Android test build from this PR and the
soninke_n_ti.kmp
package from https://jahorton.github.io/soninke_n_ti.kmp, verify that the keyboard loads properly and has proper characters for its font.