Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): prevent message-handler collision #13037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jahorton
Copy link
Contributor

Fixes: KEYMAN-IOS-1J
Fixes: #13036

@keymanapp-test-bot skip

@jahorton jahorton requested a review from sgschantz as a code owner January 24, 2025 06:58
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 24, 2025

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Comment on lines +167 to +169
if #available(iOSApplicationExtension 14.0, *) {
self.userContentController.removeAllScriptMessageHandlers()
}
Copy link
Contributor Author

@jahorton jahorton Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, we have no reports of this any earlier than iOS 15.6.1.

@github-actions github-actions bot added the fix label Jan 24, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S20 milestone Jan 24, 2025
Copy link
Contributor

@sgschantz sgschantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jahorton pushed a commit that referenced this pull request Jan 28, 2025
Fixes: KEYMAN-IOS-1J
Fixes: #13036
Cherry-pick-of: #13037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug(ios): Attempt to add script message handler with name 'keyman' when one already exists.
2 participants