feat(android): add breadcrumbing during package install about package file, source #13021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
darcywong00
reviewed
Jan 24, 2025
android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/MainActivity.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Durdin <[email protected]>
jahorton
pushed a commit
that referenced
this pull request
Jan 24, 2025
… file, source Cherry-pick-of: #13021
|
Changes in this pull request will be available for download in Keyman version 18.0.177-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few Sentry issues for Android regarding attempts to install what appear to be corrupted or malformed KMPs:
https://keyman.sentry.io/share/issue/198fe1ad9e4646a497ff7a0297b741fb/
https://keyman.sentry.io/share/issue/724a9ca295e14e0899827c0786c2d21b/
I'm sure it's a disappointment to users when this occurs, but we don't have any substantial data available to us about which packages / KMPs / files this is occurring for. So, the obvious next step: add breadcrumbing. This way, we can get a sense of what KMP sources are affected and which packages this occurs for. That, in turn, should give us a better sense of why these two errors occur.
@keymanapp-test-bot skip