fix(linux): correct permissions and paths in Linux docker image #13008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes two issues in the Linux docker image that showed up when running tests: - some directories had wrong permissions - we have to build keyman-system-service in a docker-specific directory as well so that the location of the service executable can be found when running the tests in docker
ermshiperete
requested review from
mcdurdin,
jahorton and
srl295
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
common/
common/resources/
|
nit on the PR description ( |
darcywong00
reviewed
Jan 24, 2025
| chown build:build /run/user/1000 && \ | ||
| chmod 700 /run/user/1000 && \ | ||
| mkdir -p /tmp/.X11-unix && \ | ||
| chmod 1777 /tmp/.X11-unix && \ |
There was a problem hiding this comment.
Is this not needed?
chown build:build /tmp/.X11-unix && \
There was a problem hiding this comment.
No, it should stay owned by root.
mcdurdin
changed the title
I have changed the PR title to:
This is a little more specific on what the PR is actually changing -- it's a fix not a chore, and tries to state what the fixes are. |
This changes the test script: when running in Docker it doesn't make sense to restart ibus when exiting the tests. This works around a problem where the `ibus start` command would hang.
|
Changes in this pull request will be available for download in Keyman version 18.0.177-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes two issues in the Linux docker image that showed up when running tests:
@keymanapp-test-bot skip