Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): support reversion of accepted suggestions after edits #12884

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jahorton
Copy link
Contributor

The work in this PR corresponds to this idea: #12648 (comment)

When typing rapidly, one often does not notice if the autocorrect chose wrongly. Backspacing to undo autocorrect only seems to work immediately after the spacebar is pressed; once any other keys are pressed, you have to delete the entire word and retype.

For this one... I think the "context tracker" system could, in theory, be leveraged to detect this case with some additional work. We're basically looking to revert the suggestion after a delay in this case, rather than immediately after its application. This is also presently a limitation outside of autocorrect, so it's something I could look into for the current release cycle if desired.

This PR should have user testing done on it once ready; the behavior it'll add will be user-facing.

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jan 14, 2025
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S19 milestone Jan 14, 2025
Joshua Horton added 2 commits January 14, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat user-test-missing User tests have not yet been defined for the PR web/
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant