chore: update macOS environment-variable shell script #12878
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
| export PATH="$HOMEBREW_PREFIX/opt/coreutils/libexec/gnubin:$PATH" | ||
| export JAVA_HOME=/usr/local/opt/openjdk@8 | ||
| export JAVA_HOME=/opt/homebrew/opt/java11 |
There was a problem hiding this comment.
Potential caveat: if I'm not mistaken, this path for things installed via Homebrew may be Apple Silicon specific. Granted, Mac in general is headed that way, so maybe it's not a bad thing to do this, anyway.
Might be worth a spot of discussion if I'm right about the distinction, though.
There was a problem hiding this comment.
That's right, for Intel Macs, Homebrew was in /usr/local/opt, and it uses /opt/homebrew/opt for Apple Silicon. I still use an Intel machine for my dev machine, but we should be on all Apple Silicon before too long.
There was a problem hiding this comment.
If we feel it important, I can probably make this adaptive: https://stackoverflow.com/a/65259353
It is technically possible to detect i386 vs arm in bash shell. Seems to hold in zsh too. That said, if a process in the chain is being run via Rosetta, that will cause an i386 report, according to some of the comments elsewhere in that StackOverflow thread. May need to take care.
I ran into a couple of issues when getting my Mac development laptop set up to build our Android app, some of them related to this script. One distinctly noticeable item: we use OpenJDK 11, not Java 8... yet the variables in the script still reference the latter!
Reference (current
master):keyman/docs/build/macos.md
Lines 156 to 161 in f268d04
@keymanapp-test-bot skip