change(web): add auto-correct filter that requires letter in initial position #12877
+126
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one item from the auto-correct initial feedback issue (#12648):
This is accomplished by adding a new 'filter' function to the auto-correct logic:
correctionValidForAutoSelect. A relatively simple guideline, at least for numbers, seems simple enough to define. We can use the standard programming rule for identifiers - starting with a letter. That is, if a token starts with a non-letter, we probably shouldn't do auto-correction with it.We may need to refine and polish it once auto-correct is out and we are made aware of tricky cases with different character classes, but this should be a good starting point for any such logic.
I've also added a unit-test to validate that the motivating case no longer triggers auto-correction.
@keymanapp-test-bot skip