Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): integrates predictive-text builds to top level script, reconnects headless tests #12866

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jahorton
Copy link
Contributor

@jahorton jahorton commented Jan 9, 2025

The main reason I started this PR was the fact that web/build.sh build:engine/predictive-text had absolutely no effect. Calling it when an older version of predictive-text existed on my filesystem would not update it; I had to drill-down into the child projects to get them rebuilt.

I also discovered that web's headless test suite was left disconnected for some reason. This seems to have been done at some point within the 18.0 filesystem reorganization, but was never undone. I believe things should be stable enough to reconnect them now.

For the third commit, the reorg has placed things in such a manner that it... kind of makes sense to have a web/build.sh test actually trigger them. We do still have the two separate build configurations though, so this probably shouldn't happen when doing CI testing - the third commit prevents it, but only in CI mode.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 9, 2025

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S19 milestone Jan 9, 2025
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what's the reason for treating CI and local builds differently (except for the --ci flag)?

A cursory look suggests that predictive-text/worker-main/unit_tests/test.sh test:libraries (which is called by CI) runs the same tests as allowing test runs of the child projects in predictive-text/build.sh. I'd prefer if both CI and local builds would follow the same flow, i.e. running the child actions in predictive-text/build.sh.

web/src/engine/predictive-text/build.sh Outdated Show resolved Hide resolved
web/src/engine/predictive-text/build.sh Outdated Show resolved Hide resolved
@jahorton
Copy link
Contributor Author

LGTM, but what's the reason for treating CI and local builds differently (except for the --ci flag)?

A cursory look suggests that predictive-text/worker-main/unit_tests/test.sh test:libraries (which is called by CI) runs the same tests as allowing test runs of the child projects in predictive-text/build.sh. I'd prefer if both CI and local builds would follow the same flow, i.e. running the child actions in predictive-text/build.sh.

The only reason I did this is because we have two separate CI configurations for them. After all, they used to be in vastly different sections of the repository.

If we dropped the separate predictive-text CI configuration, I'd drop the unit_tests/test.sh script and call via the child projects. We haven't dropped it (to my knowledge), and I don't wish to break that configuration at this time - that's something we should discuss as a team first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants