Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(developer,mac): add playable video links to the help documentation #12828

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

Meng-Heng
Copy link
Collaborator

@Meng-Heng Meng-Heng commented Dec 13, 2024

More on: keymanapp/help.keyman.com#1712.

The website will display the video once the img is clicked, check keymanapp/help.keyman.com#1713.

This PR is ready for review.

Edited: Hello Code owners, I may be not understanding Code owners review well. Should I be automatically requesting code owner to review this too?

@keymanapp-test-bot skip

@Meng-Heng Meng-Heng added the feat label Dec 13, 2024
@Meng-Heng Meng-Heng added this to the A18S17 milestone Dec 13, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Dec 13, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 13, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@darcywong00
Copy link
Contributor

Hello Code owners, I may be not understanding this well. Should I be automatically requesting code owner to review this too?

GitHub should automatically notify the code owners based on the files you modified, so you don't need to request unless it's been a while (3+ days)

@darcywong00
Copy link
Contributor

Since PR titles get added to the HISTORY.md changelog, I'll tweak your PR title to include the platforms.

@darcywong00 darcywong00 changed the title feat: adds playable video onto the website docs(developer,mac): Adds playable video links to the help documentation Dec 13, 2024
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Dec 13, 2024
@Meng-Heng
Copy link
Collaborator Author

Thanks @darcywong00.

@mcdurdin mcdurdin changed the title docs(developer,mac): Adds playable video links to the help documentation docs(developer,mac): add playable video links to the help documentation Dec 14, 2024
mac/docs/help/start/install-keyboard.md Outdated Show resolved Hide resolved
mac/docs/help/start/install-keyman.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the docs label Dec 16, 2024
@github-actions github-actions bot added docs and removed docs labels Dec 16, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darcywong00 darcywong00 removed this from the A18S17 milestone Dec 21, 2024
@darcywong00 darcywong00 added this to the A18S18 milestone Dec 21, 2024
@darcywong00 darcywong00 modified the milestones: A18S18, A18S19 Jan 6, 2025
@darcywong00 darcywong00 merged commit d702553 into master Jan 8, 2025
8 checks passed
@darcywong00 darcywong00 deleted the showcase-video branch January 8, 2025 01:51
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.164-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants