chore(core): remove meson warnings for wasm builds #12827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace deprecated function calls. Also add `strip` command to wasm build defaults.
ermshiperete
requested review from
mcdurdin,
darcywong00,
SabineSIL,
markcsinclair,
srl295 and
rc-swag
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
developer/
developer/compilers/
core/
ermshiperete
commented
Dec 12, 2024
| # not really a file that needs to be configured, but the `copy` parameter | ||
| # is deprecated and `fs.copyfile` doesn't work with files that are not in | ||
| # the source directory | ||
| configuration: cfg, |
There was a problem hiding this comment.
Strange thing is that fs.copyfile works in core/tests/unit/ldml/keyboards/meson.build where we also use files from outside of the current meson project. I tried but couldn't get it to work here. This is a hack I don't like, but at least it works.
rc-swag
approved these changes
Dec 13, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.159-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace deprecated function calls. Also add
stripcommand to wasm build defaults.@keymanapp-test-bot skip