-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(web): refactor JS based keyboard related class and file names 🎼 #12824
base: feat/web/loadkmx
Are you sure you want to change the base?
Conversation
User Test ResultsTest specification and instructions User tests are not required |
3c32fda
to
11cfb2e
Compare
27e7418
to
c359fe7
Compare
11cfb2e
to
a072171
Compare
c359fe7
to
b4d78ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My personal complaint here: in the long-term, the OSK should not need to be aware of whether the underlying keyboard is JS-based or LDML-based. There should be some common ancestor type between JSKeyboard and LDMLKeyboard (or similar) that provides the common properties that matter.
For example, the .isRTL
flag would need to be available in some form for LDML keyboards, too.
- needed to correctly order banner suggestions + expand long ones on the correct side
- needed to select correct BKSP and ENTER key glyphs, which are directional
Keyboards will also have a name that's displayed to the user in some form, regardless of whether they're JS or LDML. (See TitleBar
further below.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely agree. However, I'd prefer to do that in a later PR since it's unclear (at least to me) how that would be done with LDML. We can (and will have to) deal with it when we get there.
This PR is just one step further in my work with integrating LDML keyboards into Web and will require many more PRs and probably also changes to the changes that were made in this PR.
Also rename file from `kbdInterface.ts` to `jsKeyboardInterface.ts`.
Also rename file `keyboardProcessor.ts` to `jsKeyboardProcessor.ts`.
b4d78ce
to
f8ed96a
Compare
This PR renames several JS keyboard related classes and files to make it easier in upcoming changes to distinguish between JS and KMX based keyboards.
Part-of: #11293
@keymanapp-test-bot skip