Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(common/web): unit tests for element-string #12811

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

test(common/web): unit tests for element-string #12811

wants to merge 17 commits into from

Conversation

markcsinclair
Copy link
Contributor

Unit tests for kmx/kmx-plus/element-string.ts

See #9052

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 9, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@markcsinclair markcsinclair self-assigned this Dec 9, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 9, 2024
@github-actions github-actions bot added common/ common/web/ test Any acceptance test issue web/ labels Dec 9, 2024
@markcsinclair markcsinclair added web/ test Any acceptance test issue and removed web/ test Any acceptance test issue labels Dec 9, 2024
@markcsinclair markcsinclair marked this pull request as draft December 9, 2024 11:51
@github-actions github-actions bot added web/ and removed web/ labels Dec 9, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added the web/ label Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 19, 2024
@markcsinclair
Copy link
Contributor Author

markcsinclair commented Dec 19, 2024 •
edited
Loading

If the order or tertiary arguments to ElementString.fromString() are too short, the function inserts NaN into the corresponding ElemElement. The same is true if either argument contains non-number items.

@github-actions github-actions bot added web/ and removed web/ labels Dec 19, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 19, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 19, 2024
@github-actions github-actions bot added web/ and removed web/ labels Dec 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S17, A18S18 Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@mcdurdin mcdurdin Awaiting requested review from mcdurdin mcdurdin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@markcsinclair markcsinclair

Labels
common/web/ common/ test Any acceptance test issue web/
Projects
Keyman
Status: No status
Milestone
A18S18
Development

Successfully merging this pull request may close these issues.
2 participants
@markcsinclair @darcywong00