test(common/web): unit tests for element-string #12811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
markcsinclair
added
web/
test
…052-unit-tests-element-string
… on fromStrings() in isEqual() tests
…052-unit-tests-element-string
|
Ready for review. Two fixes will be needed to cover the issues addressed by skipped tests. |
…052-unit-tests-element-string
srl295
reviewed
Jan 17, 2025
Comment on lines
+361
to
+366
| const actual = ElementString.fromStrings(sections, "\\ud800\\udf30"); | ||
| const expected = [ | ||
| initElemElement(HI_GOTHIC_A), | ||
| initElemElement(LO_GOTHIC_A), | ||
| ]; | ||
| assert.deepEqual(actual, expected); |
There was a problem hiding this comment.
this will work here, but is tested for in the keyboard compiler to be avoided ( the \\ud800 and \\udf30 will be rejected)
srl295
approved these changes
Jan 17, 2025
|
Sorry for the delay! Maybe best to test w/ update before merging |
…052-unit-tests-element-string
markcsinclair
deleted the
test/common/web/types/9052-unit-tests-element-string
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.170-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for
kmx/kmx-plus/element-string.tsSee #9052
@keymanapp-test-bot skip