Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(developer): km_core_keyboard_load_from_blob in debugger 🎼 #12711

Conversation

mcdurdin
Copy link
Member

Replaces km_core_keyboard_load with km_core_keyboard_load_from_blob.

Fixes: #12690

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(developer): km_core_keyboard_load_from_blob in debugger refactor(developer): km_core_keyboard_load_from_blob in debugger 🎼 Nov 27, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S16 milestone Nov 27, 2024
Replaces `km_core_keyboard_load` with `km_core_keyboard_load_from_blob`.

Fixes: #12690
@mcdurdin mcdurdin force-pushed the refactor/developer/12690-km_core_keyboard_load_from_blob branch from 9be0876 to b5b1747 Compare November 27, 2024 01:57
@darcywong00 darcywong00 self-assigned this Nov 27, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit 226f60c into epic/web-core Nov 27, 2024
3 checks passed
@mcdurdin mcdurdin deleted the refactor/developer/12690-km_core_keyboard_load_from_blob branch November 27, 2024 02:58
ermshiperete pushed a commit that referenced this pull request Nov 27, 2024
Replaces `km_core_keyboard_load` with `km_core_keyboard_load_from_blob`.

Fixes: #12690
Cherry-pick: #12711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

refactor(developer): implement loading of keyboard blob in Keyman Developer
2 participants