feat(linux): rename symbols throughout mcompile-linux 🐘 #11761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
bot
changed the title
ermshiperete
approved these changes
Jun 12, 2024
github-actions
bot
added
windows/
windows/engine/
linux/engine/
and removed
linux/engine/
labels
ermshiperete
approved these changes
Jun 14, 2024
SabineSIL
merged commit a305176
into
feat/linux/mcompile-DoConvert-read
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes parts of PR #9384
This PR addresses and bundles comments made on PR #9384 about renaming symbols.
While reviewing PR #9384 several comments on renaming symbols came up. Most of them address the use of non-capital letters in variable names, renaming symbols to other names and adding comments into the code.
This PR only addresses requests for changes in comments and symbol names throughout all mcompile-linux. There might still be other unaddressed comments in functions or modules that have already had symbols renamed.
@keymanapp-test-bot skip