Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): remove allowJs from web's tsconfig.base.json #11718

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jun 6, 2024

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S3 milestone Jun 6, 2024
@mcdurdin
Copy link
Member Author

mcdurdin commented Jun 6, 2024

Fails web test:

12:07:31   [web/src/tools/building/sourcemap-root] dependency build, started by web/src/app/browser
12:07:31   [web/src/tools/building/sourcemap-root] build.sh parameters: <configure build --deps --builder-dep-parent web/src/app/browser>
12:07:31   [web/src/tools/building/sourcemap-root] skipping configure, up-to-date
12:07:31   [web/src/tools/building/sourcemap-root] skipping build, up-to-date
12:07:31   (node:694905) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
12:07:31   (Use `node --trace-warnings ...` to show where the warning was created)
12:07:31   (node:694905) ExperimentalWarning: The Node.js specifier resolution flag is experimental. It could change or be removed at any time.
12:07:41   
12:07:41   TSError: ⨯ Unable to compile TypeScript:
12:07:41   ../../../../../common/web/input-processor/build/obj/index.js(1,22): error TS6053: File '/var/lib/TeamCity/work/99b311828f4ee7c/keyman/common/web/predictive-text/src/worker-interface.d.ts' not found.
12:07:41   
12:07:41       at createTSError (/var/lib/TeamCity/work/99b311828f4ee7c/keyman/node_modules/ts-node/src/index.ts:859:12)
12:07:41       at reportTSError (/var/lib/TeamCity/work/99b311828f4ee7c/keyman/node_modules/ts-node/src/index.ts:863:19)
12:07:41       at getOutput (/var/lib/TeamCity/work/99b311828f4ee7c/keyman/node_modules/ts-node/src/index.ts:1077:36)
12:07:41       at Object.compile (/var/lib/TeamCity/work/99b311828f4ee7c/keyman/node_modules/ts-node/src/index.ts:1433:41)
12:07:41       at transformSource (/var/lib/TeamCity/work/99b311828f4ee7c/keyman/node_modules/ts-node/src/esm.ts:400:37)
12:07:41       at /var/lib/TeamCity/work/99b311828f4ee7c/keyman/node_modules/ts-node/src/esm.ts:278:53
12:07:41       at async addShortCircuitFlag (/var/lib/TeamCity/work/99b311828f4ee7c/keyman/node_modules/ts-node/src/esm.ts:409:15)
12:07:41       at async nextLoad (node:internal/modules/esm/loader:163:22)
12:07:41       at async ESMLoader.load (node:internal/modules/esm/loader:603:20)
12:07:41       at async ESMLoader.moduleProvider (node:internal/modules/esm/loader:457:11)

https://build.palaso.org/buildConfiguration/Keymanweb_TestPullRequests/469868?buildTab=log&linesState=711&logView=flowAware&focusLine=1960

@github-actions github-actions bot added common/ and removed common/ labels Jun 6, 2024
@jahorton
Copy link
Contributor

jahorton commented Jun 6, 2024

The current error is being triggered during ./web/build.sh test:app/browser and will also be triggered with ./web/build.sh test:engine/osk. It appears that running under ts-node mode is failing to find a type-definition file, somehow, because of the changes involved - though it's not clear why.

Sadly, I don't get well-detailed error reports like this on my dev machines - both return a generic "ERROR: null" for me.

The cleanest way forward may be to precompile the TS tests used by Web... and I think I've about got something worked out for that now. See #11723 below, which I've based on this PR.

@mcdurdin mcdurdin merged commit 8d3c66b into master Jun 7, 2024
13 of 14 checks passed
@mcdurdin mcdurdin deleted the fix/common/11716-remove-allowJs-from-web-tsconfig branch June 7, 2024 02:20
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.51-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants