fix(linux): move environment to separate job and checkout to separate subdirectory #11659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
approved these changes
Jun 3, 2024
ermshiperete
changed the title
… dir In #11571 we tried to fix the failing API verification by moving setting up the environment and restoring artifacts to the same job as the api verification itself. However, this doesn't help and the `artifacts` subdirectory still vanishes, caused by actions/checkout#1201. This change reverts the change introduced in #11571 and changes the git checkout to end in a separate subdirectory. Reverts: #11571
ermshiperete
force-pushed
the
fix/linux/apiverification
branch
from
218a5f5 to
a858f63
Compare
ermshiperete
added a commit
that referenced
this pull request
Jun 3, 2024
This change reverts #11659 and moves setting the environment and restoring the artifacts in the same job as the actual API verification. It keeps checking out the git files to a separate directory.
|
Changes in this pull request will be available for download in Keyman version 18.0.47-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11571 we tried to fix the failing API verification by moving setting up the environment and restoring artifacts to the same job as the api verification itself. However, this doesn't help and the
artifactssubdirectory still vanishes, caused by actions/checkout#1201.This change reverts the change introduced in #11571 and changes the git checkout to end in a separate subdirectory.
Reverts: #11571
@keymanapp-test-bot skip