refactor(common): move kpj-related files into developer-utils 🐉 #11531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
developer/
common/
developer/compilers/
common/web/
refactor
labels
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
In preparation for moving source file types into developer-utils, move the existing developer-utils files into src/ and src/utils subfolders.
Moves the kpj test fixtures into developer-utils, moves from let to const in code where required by eslint, and reduces the coverage threshold in order to get tests to pass for developer-utils.
As we move some better-tested areas out of common-types, it looks like our overall coverage goes down.
mcdurdin
force-pushed
the
refactor/common/9665-move-project-file-type-to-developer
branch
from
25f944c to
071fe5c
Compare
jahorton
approved these changes
Aug 1, 2024
mcdurdin
deleted the
refactor/common/9665-move-project-file-type-to-developer
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.84-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9665.
In preparation for moving source file types into developer-utils, move the existing developer-utils files into src/ and src/utils subfolders.
Moves the kpj test fixtures into developer-utils, moves from let to const in code where required by eslint, and reduces the coverage threshold in order to get tests to pass for developer-utils.
As we move some better-tested areas out of common-types, it looks like our overall coverage goes down there, but it also went down in developer-utils! 😭
@keymanapp-test-bot skip