fix(android/engine): Ignore updating invalid selections #11510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11506
Fixes KEYMAN-ANDROID-3A2
Fixes KEYMAN-ANDROID-3Z4 (second time)
This adds more sanity-checking to
KMKeyboard.updateSelectionRange()
. Will 🍒 pick to stable-17.0Don't attempt to process selection if
I can verify these hit the debugger (selMax is 23 when the raw text length is 23). But I can't repro the crashes in the Sentry issue.
User Testing
Setup - Install the PR build of Keyman for Android