Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android/engine): Handle globe key on lock screen #11458

Merged
merged 1 commit into from
May 16, 2024

Conversation

darcywong00
Copy link
Contributor

@dinakaranr reported the Keyman globe wasn't responding on the lock screen.

This fixes the transition on the lock screen to handle the Globe key on key press (GLOBE_KEY_STATE_DOWN).

Will 🍒 pick to stable-17.0

User Testing

Setup -

  1. Install the PR build of Keyman for Android on an emulator. Best to use an emulator in case the lock screen gets stuck on the wrong keyboard for entering the password.
  2. On the Android emulator Settings, set the lock screen to use a password of "qwerty".

TEST_KEYMAN_LOCK_SCREEN - Verifies Keyman globe key on lock screen

  1. Launch Keyman
  2. From "Get Started", set Keyman as the default ksystem keyboard.
  3. Launch Chrome and select a text field.
  4. Switch to Keyman if it's no the current keyboard.
  5. Lock the emulator
  6. Press button to enter the lock screen
  7. With Keyman on the lock screen, press and release the globe key
  8. Verify the keyboard switches to another system keyboard (non-Keyman).

@darcywong00 darcywong00 requested a review from sgschantz as a code owner May 16, 2024 02:24
@darcywong00 darcywong00 added this to the A18S2 milestone May 16, 2024
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels May 16, 2024
@github-actions github-actions bot added android/ android/engine/ and removed user-test-required User tests have not been completed labels May 16, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented May 16, 2024

User Test Results

Test specification and instructions

  • TEST_KEYMAN_LOCK_SCREEN (PASSED): I tested this issue with the attached "Keyman 18.0.37-alpha-test-11458" build on Android 14 (emulator and physical devices) environment: Here is my observation. (notes)

Test Artifacts

@github-actions github-actions bot added the fix label May 16, 2024
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-required User tests have not been completed label May 16, 2024
@dinakaranr
Copy link

Test Results

  • TEST_KEYMAN_LOCK_SCREEN (PASSED): I tested this issue with the attached "Keyman 18.0.37-alpha-test-11458" build on Android 14 (emulator and physical devices) environment: Here is my observation.
  1. Installed the "Keyman-18.0.37.apk" file and gave all permissions to the application.
  2. Checked the "Enable Keyman as system-wide keyboard" and set the keyboard as the default keyboard box on the settings page.
  3. Open the Keyman App and then add any two keyboards.
  4. On Android 14 Mobile and Emulator: set the lock screen to use a password of "qwerty."
  5. Press the lock button on the mobile.
  6. On Lock screen: The Keyman keyboard appears on the lock screen. Press the globe key and then observe that the keyman switches from English to another language.
    If Keyman had only one keyboard and then switched to another system keyboard(Gboard). It works well. Thank you.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label May 16, 2024
@darcywong00 darcywong00 merged commit d4fd52c into master May 16, 2024
6 checks passed
@darcywong00 darcywong00 deleted the fix/android/lock-globe branch May 16, 2024 15:04
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.37-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants