refactor(core): remove unused context APIs 🌱 #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10431. The `km_core_` prefix has been removed from internal-only functions, and these function declarations moved to context.hpp. The functions have not been moved from km_core_context_api.cpp at this stage. Rewrote the function documentation in Javadoc style comments for the internal use functions.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
mcdurdin
requested review from
ermshiperete,
darcywong00 and
rc-swag
as code owners
ermshiperete
approved these changes
Jan 18, 2024
Base automatically changed from
chore/core/10424-surrogate-pair-tests
to
epic/core/9999-normalization
January 19, 2024 02:51
|
Debian packaging failed with: |
…remove-unused-core-context-apis
|
KeymanWeb build is flaky (#10494). Not related to anything here. |
mcdurdin
merged commit e8e47c0
into
epic/core/9999-normalization
14 of 16 checks passed
mcdurdin
deleted the
refactor/core/10431-remove-unused-core-context-apis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10431.
The
km_core_prefix has been removed from internal-only functions, and these function declarations moved to context.hpp.The functions have not been moved from km_core_context_api.cpp at this stage.
Rewrote the function documentation in Javadoc style comments for the internal use functions.
TODO: km_core_context_get is required by Developer
@keymanapp-test-bot skip