feat(core): cross-segment markers 🙀 #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
- support out-of-order re-adding - test for updated marker map
srl295
force-pushed
the
feat/core/10369-marker-sequence-again-epic-ldml
branch
from
94dbff9 to
565a1ca
Compare
Base automatically changed from
feat/developer/10319-remove-old-escape-epic-ldml
to
master
January 18, 2024 16:38
srl295
force-pushed
the
feat/core/10369-marker-sequence-again-epic-ldml
branch
from
565a1ca to
6f5cee0
Compare
- split out parse_next_marker() - use NFD safe boundaries to segment marker interaction For: #10369
srl295
force-pushed
the
feat/core/10369-marker-sequence-again-epic-ldml
branch
from
6f5cee0 to
3ccffe9
Compare
- easier to understand loop - comments For: #10369
srl295
changed the title
- remove unused function For: #10369
mcdurdin
approved these changes
Jan 19, 2024
core/src/ldml/ldml_markers.cpp
Outdated
| } | ||
| } | ||
| // assert(marki == map.rend()); // that we consumed everything |
There was a problem hiding this comment.
good catch Should have been map2, but it wasn't the right assert. added a better assert now.
Co-authored-by: Marc Durdin <[email protected]>
|
Changes in this pull request will be available for download in Keyman version 17.0.248-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(char32_t, marker_num)pairs instead of a map#10369
@keymanapp-test-bot skip