refactor(web): transformation of build-bundler into a common es-bundling command 📜 #10265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
reviewed
Dec 20, 2023
jahorton
commented
Dec 20, 2023
… refactor/web/common-esbundling
…esbundling' into refactor/web/common-esbundling
Base automatically changed from
change/web/lm-worker-bundling-cleanup
to
master
January 8, 2024 08:53
|
Changes in this pull request will be available for download in Keyman version 17.0.239-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the big ES-modularization work (🧩) of this (17.0) release cycle, I created a lot of
build-bundler.jsscripts - roughly one per .tsconfig project. Many of them are very similar to each other. In #9025, the various configurations were cleaned up and DRY-ed out, but the code using those configurations... that never got reworked and is thus still WET. Until now.If this is not tackled at least somewhat now, the problem will continue to proliferate when pursuing separate ES6 artifacts for Web builds - they'd need their own custom versions. (See #10257.)
As I did with the lm-worker's other two scripts in #10264, the WET
build-bundlerscript has been reworked with parameterization. But, rather than leave it in thelm-worker's space... I have instead implemented this as a common command-script within thecommon/web/es-bundlingresource project.While none of the other Web projects aside from
lm-workerutilize it - yet - we should be able to replace mostbuild-bundler.jscalls, over time, with calls into this common script instead. Much of this will be done within #10267.@keymanapp-test-bot skip