Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(windows): Online Update check stream update data 💽 #10042

Merged
merged 2 commits into from
Nov 28, 2023
Merged

feat(windows): Online Update check stream update data 💽 #10042

merged 2 commits into from
Nov 28, 2023

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 22, 2023 •
edited
Loading

Fixes #10045
Relates to #10038.

Starts to refactor the online update check in Windows so that the results are stored to disk and can be checked at any time. This commit:

  • removes keepintouch frame
  • adds update frame
  • adds serialization of update check data
  • presents the serialized update check data in the update frame

Online updates won't currently work, as more work is needed in follow-up PRs

Screenshots

When no update is available:

image

When updates are available:

image

Note: the 'SKUpdate_...' text will be replaced with the actual update description in a full build.

TODO

  • Add Keep in Touch link to Support tab
  • Cleanup the layout of the Update tab
    • Remove checkmarks for selecting updates to Update tab
    • Add strings for Update tab
    • Icon for the update tab
    • Red circled number for #updates available in the left-hand menu Update item
  • Provide actual 'status' text relevant to current cache status

@mcdurdin
feat(windows): Online Update check stream update data
8756e40 
Starts to refactor the online update check in Windows so that the
results are stored to disk and can be checked at any time. This commit:
* removes keepintouch frame
* adds update frame
* adds serialization of update check data
* presents the serialized update check data in the update frame

Online updates won't currently work.
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Nov 22, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 22, 2023 •
edited
Loading

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(windows): Online Update check stream update data feat(windows): Online Update check stream update data 💽 Nov 22, 2023
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S26 milestone Nov 22, 2023
@rc-swag rc-swag linked an issue Nov 22, 2023 that may be closed by this pull request
feat(windows): Update Tab for Keyman Configuration as per functional spec 💽 #10045
Closed
1 task
@rc-swag rc-swag mentioned this pull request Nov 22, 2023
Open
22 tasks
@mcdurdin mcdurdin marked this pull request as ready for review November 24, 2023 23:00
@darcywong00 darcywong00 modified the milestones: A17S26, A17S27 Nov 27, 2023
ermshiperete
ermshiperete approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: the 'SKUpdate_...' text will be replaced with the actual update description in a full build.

I assume these lines in the table are keyboards that have an update available?

windows/src/desktop/kmshell/kmshell.dpr Outdated Show resolved Hide resolved
rc-swag
rc-swag approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rc-swag rc-swag merged commit 79f65a1 into epic/windows-updates Nov 28, 2023
3 of 8 checks passed
@rc-swag rc-swag deleted the feat/windows/10038-windows-update-ui branch November 28, 2023 04:06
@mcdurdin
Copy link
Member Author

I assume these lines in the table are keyboards that have an update available?

Yes

@rc-swag
Copy link
Contributor

rc-swag commented Jan 8, 2024

Just a note I think the "strings.xml" update must be missing from this check-in. It is needed for display the "Apply updates now" and the "Check for new updates". Also not sure which icon image is used for the windows update. I can add these quickly but thought I might mention it in the off chance @mcdurdin still has the update on his machine.

@mcdurdin
Copy link
Member Author

I can add these quickly but thought I might mention it in the off chance @mcdurdin still has the update on his machine.

I don't think I have them? I'm not 100% sure what you are looking for though?

@rc-swag
Copy link
Contributor

rc-swag commented Jan 12, 2024

I can add these quickly but thought I might mention it in the off chance @mcdurdin still has the update on his machine.

I don't think I have them? I'm not 100% sure what you are looking for though?

No problem I have added them on one of my branches. S_Button_Update_ApplyNow and S_Button_Update_Check in keyman_update.xsl do not have entries in strings.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rc-swag rc-swag rc-swag approved these changes

@ermshiperete ermshiperete ermshiperete approved these changes

Assignees
No one assigned
Labels
common/ epic-windows-updates feat user-test-missing User tests have not yet been defined for the PR windows/config/ windows/
Projects
None yet
Milestone
A17S27
Development

Successfully merging this pull request may close these issues.

feat(windows): Update Tab for Keyman Configuration as per functional spec 💽
4 participants
@mcdurdin @rc-swag @ermshiperete @darcywong00