Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(common/web): StrsItem does not have an isEqual() method, so ElemElement.isEqual() and ElementString.isEqual() cannot detect clones #12867

Open
1 of 8 tasks
markcsinclair opened this issue Jan 9, 2025 · 0 comments · May be fixed by #12868
Open
1 of 8 tasks

bug(common/web): StrsItem does not have an isEqual() method, so ElemElement.isEqual() and ElementString.isEqual() cannot detect clones #12867

markcsinclair opened this issue Jan 9, 2025 · 0 comments · May be fixed by #12868
Assignees
@markcsinclair
Labels
bug common/web/ common/ web/
Milestone
A18S19

Comments

@markcsinclair
Copy link
Contributor

markcsinclair commented Jan 9, 2025 •
edited
Loading

Describe the bug

StrsItem does not have an isEqual() method, so ElemElement.isEqual() and ElementString.isEqual() cannot detect clones.

Skipped test cases in element-string-tests.ts (PR #12811) cover this.

An isEqual() method needs to be added to StrsItem, and the ElemElement.isEqual() updated to use it rather than a.value === this.value.

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markcsinclair markcsinclair

Labels
bug common/web/ common/ web/
Projects
Keyman
Status: No status
Milestone
A18S19
Development

Successfully merging a pull request may close this issue.

fix(common/web): add StrsItem.isEqual() method keymanapp/keyman
1 participant
@markcsinclair